Conversation
thomhurst
added
dependencies
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
Type: Dependency update (Renovate Bot — patch bump)
Summary
This PR updates all TUnit-family packages from → across two surfaces:
- **** — central version management for the repo's own test/tooling dependencies (TUnit, TUnit.Assertions, TUnit.AspNetCore, TUnit.Core, TUnit.Engine, TUnit.Assertions.FSharp)
- Template project files — the starter templates shipped to users (TUnit.AspNet, TUnit.AspNet.FSharp, TUnit.FSharp, TUnit.Playwright, TUnit.VB)
Observations
- Consistency ✅ — All 7 packages are bumped to the same version (), so there are no mismatched versions between related packages.
- Correct surfaces updated ✅ — Both the central and the individual template // files are updated. Template files pin their own versions independently (they don't consume ), so this dual update is correct and necessary.
- Patch-range update ✅ — The 14-version jump ( → ) is all within the same minor version, so no breaking changes are expected per semver. The included release notes confirm the changes are bug fixes and features (covariant assertions, string length range assertions, hook fixes, etc.) — nothing that should require changes to template content.
- No missing packages — is correctly updated in its template file only (not in because the main repo doesn't consume it directly). This is consistent with the existing pattern.
No issues found
The PR is mechanically correct and well-scoped. No architectural concerns — this is exactly the right approach for managing package versions in a repo that both consumes and publishes TUnit.
Contributor
There was a problem hiding this comment.
Code Review
Type: Dependency update (Renovate Bot — patch bump)
Summary
This PR updates all TUnit-family packages from 1.21.6 to 1.21.20 across two surfaces:
- Directory.Packages.props — central version management for the repo's own test/tooling dependencies (TUnit, TUnit.Assertions, TUnit.AspNetCore, TUnit.Core, TUnit.Engine, TUnit.Assertions.FSharp)
- Template project files — the starter templates shipped to users (TUnit.AspNet, TUnit.AspNet.FSharp, TUnit.FSharp, TUnit.Playwright, TUnit.VB)
Observations
- Consistency — All 7 packages are bumped to the same version (1.21.20), so there are no mismatched versions between related packages.
- Correct surfaces updated — Both the central Directory.Packages.props and the individual template .csproj/.fsproj/.vbproj files are updated. Template files pin their own versions independently (they do not consume Directory.Packages.props), so this dual update is correct and necessary.
- Patch-range update — The 14-version jump (1.21.6 to 1.21.20) is all within the same minor version, so no breaking changes are expected per semver. The included release notes confirm the changes are bug fixes and features (covariant assertions, string length range assertions, hook fixes, etc.) — nothing that should require changes to template content.
- No missing packages — TUnit.Playwright is correctly updated in its template file only (not in Directory.Packages.props because the main repo does not consume it directly). This is consistent with the existing pattern.
Verdict
No issues found. The PR is mechanically correct and well-scoped. No architectural concerns — this is exactly the right approach for managing package versions in a repo that both consumes and publishes TUnit.
This was referenced Mar 25, 2026
This was referenced Mar 26, 2026
intellitect-bot
pushed a commit
to IntelliTect/EssentialCSharp.Web
that referenced
this pull request
Mar 26, 2026
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.21.20 to 1.21.24. <details> <summary>Release notes</summary> _Sourced from [TUnit's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.21.24 <!-- Release notes generated using configuration in .github/release.yml at v1.21.24 --> ## What's Changed ### Other Changes * Fix OpenTelemetry missing root span by reordering session activity lifecycle by @Copilot in thomhurst/TUnit#5245 ### Dependencies * chore(deps): update tunit to 1.21.20 by @thomhurst in thomhurst/TUnit#5241 * chore(deps): update dependency stackexchange.redis to 2.12.8 by @thomhurst in thomhurst/TUnit#5243 **Full Changelog**: thomhurst/TUnit@v1.21.20...v1.21.24 Commits viewable in [compare view](thomhurst/TUnit@v1.21.20...v1.21.24). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.21.6→1.21.201.21.6→1.21.201.21.6→1.21.201.21.6→1.21.201.21.6→1.21.201.21.6→1.21.201.21.6→1.21.20Release Notes
thomhurst/TUnit (TUnit)
v1.21.20: 1.21.20What's Changed
Other Changes
Dependencies
Full Changelog: v1.21.6...v1.21.20
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.